Merged
Conversation
Afaik, nobody is using it. I've never used it myself. 1) atomic, os.Write, map, codec benchmarks all seem temporary and to be of no use in the future. 2) syncing benchmark may be useful, but we're trying to move away from Bash. Also, the blocks are empty there.
Codecov Report
@@ Coverage Diff @@
## master #3999 +/- ##
==========================================
+ Coverage 66.6% 67.18% +0.57%
==========================================
Files 225 245 +20
Lines 18737 20573 +1836
==========================================
+ Hits 12480 13822 +1342
- Misses 5321 5716 +395
- Partials 936 1035 +99
|
tac0turtle
approved these changes
Sep 19, 2019
Contributor
|
changelog_pending entry? |
Contributor
Author
no need |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Afaik, nobody is using it. I've never used it myself.
of no use in the future.
Bash. Also, the blocks are empty there.