Closed
Conversation
- protoc 3.7.0 - github.com/gogo/protobuf#8a5ed79f688836cf007ca23aefe0299791e7bea5 This brings compatibility with protobuf files built with newer versions of the marshaller and marshaller_all extensions. In particular the MarshalToSizedBuffer functions Signed-off-by: Silas Davis <silas@monax.io>
88a6036 to
8f79536
Compare
Contributor
|
5 tasks
Contributor
|
Closing for #3998 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/hyperledger/burrow has compile time errors with the abci types.pb.go file because our protobuf generated files expect the
MarshalToSizedBufferfunction. This updates your pb generated files which fixes this issue and gives you a newer version of the gogo generated code.Using:
This brings compatibility with protobuf files built with newer versions
of the marshaller and marshaller_all extensions. In particular the
MarshalToSizedBuffer functions
Signed-off-by: Silas Davis silas@monax.io