Fix linter errors thrown by maligned and interfacer#3959
Merged
melekes merged 22 commits intotendermint:masterfrom Oct 1, 2019
Merged
Fix linter errors thrown by maligned and interfacer#3959melekes merged 22 commits intotendermint:masterfrom
maligned and interfacer#3959melekes merged 22 commits intotendermint:masterfrom
Conversation
melekes
reviewed
Sep 9, 2019
Contributor
melekes
left a comment
There was a problem hiding this comment.
Thanks for contributing to Tendermint 👍
golangcibot
reviewed
Sep 10, 2019
796e685 to
46d0c86
Compare
melekes
reviewed
Sep 14, 2019
Contributor
|
…tendermint into go-green/maligned-interfacer
Codecov Report
@@ Coverage Diff @@
## master #3959 +/- ##
==========================================
- Coverage 66.6% 66.53% -0.07%
==========================================
Files 225 225
Lines 18737 18737
==========================================
- Hits 12480 12467 -13
- Misses 5321 5334 +13
Partials 936 936
|
melekes
approved these changes
Sep 22, 2019
golangcibot
reviewed
Sep 30, 2019
melekes
approved these changes
Sep 30, 2019
Contributor
|
Can we actually enable maligned and interfacer linters in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR repairs linter errors seen when running the following commands:
golangci-lint run --no-config --disable-all=true --enable=malignedgolangci-lint run --no-config --disable-all=true --enable=interfacerContributes to #3262