Skip to content

Remove mentions of go-wire#3904

Merged
melekes merged 4 commits intomasterfrom
marko/2790_clean_gowire
Aug 16, 2019
Merged

Remove mentions of go-wire#3904
melekes merged 4 commits intomasterfrom
marko/2790_clean_gowire

Conversation

@tac0turtle
Copy link
Contributor

  • Cleanup go-wire mentions
  • remove Roadmap.md
  • build_race in makefile was failing

ref #2790

Signed-off-by: Marko Baricevic marbar3778@yahoo.com

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

- remove Roadmap.md
- build_race in makefile was failing

Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
@tac0turtle tac0turtle added the T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. label Aug 16, 2019
@tac0turtle tac0turtle requested a review from melekes August 16, 2019 09:35
@codecov-io
Copy link

codecov-io commented Aug 16, 2019

Codecov Report

Merging #3904 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #3904      +/-   ##
==========================================
- Coverage   66.99%   66.97%   -0.03%     
==========================================
  Files         219      219              
  Lines       18205    18205              
==========================================
- Hits        12196    12192       -4     
- Misses       5123     5127       +4     
  Partials      886      886
Impacted Files Coverage Δ
rpc/core/routes.go 0% <ø> (ø) ⬆️
consensus/state.go 80.18% <0%> (+0.23%) ⬆️
p2p/pex/errors.go 12.5% <0%> (-12.5%) ⬇️
privval/signer_server.go 91.3% <0%> (-4.35%) ⬇️
p2p/pex/pex_reactor.go 84.34% <0%> (-0.58%) ⬇️
p2p/pex/addrbook.go 67.83% <0%> (-0.51%) ⬇️
consensus/reactor.go 78.07% <0%> (-0.24%) ⬇️
blockchain/v0/pool.go 81.31% <0%> (+0.65%) ⬆️
consensus/replay.go 71.77% <0%> (+0.8%) ⬆️

Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥑

@melekes melekes merged commit eec6d33 into master Aug 16, 2019
@melekes melekes deleted the marko/2790_clean_gowire branch August 16, 2019 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants