Skip to content

Remove instances of cmn.Error (2/2)#3890

Merged
melekes merged 5 commits intomasterfrom
marko/remove_cmnError
Aug 11, 2019
Merged

Remove instances of cmn.Error (2/2)#3890
melekes merged 5 commits intomasterfrom
marko/remove_cmnError

Conversation

@tac0turtle
Copy link
Contributor

@tac0turtle tac0turtle commented Aug 9, 2019

Replace usage of cmnError and errorWrap

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

- Replace usage of cmnError and errorWrap
- ref #3862

Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
@tac0turtle tac0turtle added the T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. label Aug 9, 2019
@tac0turtle tac0turtle requested review from ebuchman and melekes August 9, 2019 13:11
@tac0turtle tac0turtle requested a review from xla as a code owner August 9, 2019 13:11
@codecov-io
Copy link

codecov-io commented Aug 9, 2019

Codecov Report

Merging #3890 into master will decrease coverage by 0.08%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##           master    #3890      +/-   ##
==========================================
- Coverage   65.05%   64.96%   -0.09%     
==========================================
  Files         217      217              
  Lines       18193    18210      +17     
==========================================
- Hits        11836    11831       -5     
- Misses       5446     5460      +14     
- Partials      911      919       +8
Impacted Files Coverage Δ
lite/proxy/query.go 7.35% <0%> (ø) ⬆️
lite/proxy/verifier.go 0% <0%> (ø) ⬆️
cmd/tendermint/commands/lite.go 17.5% <0%> (ø) ⬆️
p2p/conn/connection.go 80.97% <0%> (+0.25%) ⬆️
lite/proxy/errors.go 0% <0%> (ø) ⬆️
privval/utils.go 35.48% <100%> (+2.15%) ⬆️
crypto/merkle/simple_proof.go 68.22% <100%> (ø) ⬆️
lite/base_verifier.go 67.85% <50%> (ø) ⬆️
privval/signer_endpoint.go 76% <0%> (-8%) ⬇️
libs/events/events.go 93.2% <0%> (-4.86%) ⬇️
... and 11 more

@melekes melekes merged commit 8a282a5 into master Aug 11, 2019
@melekes melekes deleted the marko/remove_cmnError branch August 11, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants