Skip to content

(1/2) of replace errors.go with github.com/pkg/errors#3888

Merged
melekes merged 3 commits intomasterfrom
marko/errorReplace
Aug 8, 2019
Merged

(1/2) of replace errors.go with github.com/pkg/errors#3888
melekes merged 3 commits intomasterfrom
marko/errorReplace

Conversation

@tac0turtle
Copy link
Contributor

ref #3862

  • step one in removing instances of errors.go in favor of github.com/pkg/errors

Signed-off-by: Marko Baricevic marbar3778@yahoo.com

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

ref #3862

- step one in removing instances of errors.go in favor of github.com/pkg/errors

Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
@tac0turtle tac0turtle added T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. ready-for-review labels Aug 8, 2019
@tac0turtle tac0turtle requested a review from melekes August 8, 2019 08:19
@tac0turtle tac0turtle requested review from ebuchman and xla as code owners August 8, 2019 08:19
@codecov-io
Copy link

codecov-io commented Aug 8, 2019

Codecov Report

Merging #3888 into master will increase coverage by 0.04%.
The diff coverage is 31.25%.

@@            Coverage Diff             @@
##           master    #3888      +/-   ##
==========================================
+ Coverage   64.91%   64.96%   +0.04%     
==========================================
  Files         217      217              
  Lines       18194    18211      +17     
==========================================
+ Hits        11810    11830      +20     
- Misses       5463     5464       +1     
+ Partials      921      917       -4
Impacted Files Coverage Δ
privval/messages.go 100% <ø> (ø) ⬆️
p2p/switch.go 68.69% <0%> (ø) ⬆️
p2p/test_util.go 63.97% <0%> (ø) ⬆️
crypto/merkle/proof_simple_value.go 0% <0%> (ø) ⬆️
crypto/merkle/proof_key_path.go 80.64% <33.33%> (ø) ⬆️
crypto/merkle/proof.go 40.35% <57.14%> (ø) ⬆️
p2p/pex/pex_reactor.go 82.02% <0%> (-0.58%) ⬇️
blockchain/v0/pool.go 80.65% <0%> (-0.33%) ⬇️
privval/signer_server.go 95.65% <0%> (ø) ⬆️
p2p/errors.go 20.33% <0%> (+1.29%) ⬆️
... and 3 more

Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@melekes melekes merged commit 8dc39b6 into master Aug 8, 2019
@melekes melekes deleted the marko/errorReplace branch August 8, 2019 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants