Skip to content

docs: "Writing a Tendermint Core application in Java (gRPC)" guide#3887

Merged
melekes merged 4 commits intotendermint:masterfrom
climber73:abci-grpc-java-guide
Aug 12, 2019
Merged

docs: "Writing a Tendermint Core application in Java (gRPC)" guide#3887
melekes merged 4 commits intotendermint:masterfrom
climber73:abci-grpc-java-guide

Conversation

@climber73
Copy link
Contributor

Refs #3808

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

@climber73 climber73 force-pushed the abci-grpc-java-guide branch from 838118e to 4359cac Compare August 8, 2019 05:27
@climber73
Copy link
Contributor Author

@melekes thank you for thorough review, and sorry for my English

@codecov-io
Copy link

Codecov Report

Merging #3887 into master will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3887      +/-   ##
==========================================
+ Coverage   64.91%   64.97%   +0.06%     
==========================================
  Files         217      217              
  Lines       18194    18211      +17     
==========================================
+ Hits        11810    11832      +22     
+ Misses       5463     5462       -1     
+ Partials      921      917       -4
Impacted Files Coverage Δ
consensus/state.go 80.18% <0%> (ø) ⬆️
consensus/reactor.go 71.39% <0%> (+0.35%) ⬆️
consensus/replay.go 72.17% <0%> (+1.2%) ⬆️
p2p/errors.go 20.33% <0%> (+1.29%) ⬆️
p2p/pex/pex_reactor.go 84.34% <0%> (+1.73%) ⬆️
privval/signer_endpoint.go 84% <0%> (+2.66%) ⬆️
consensus/ticker.go 95.83% <0%> (+4.16%) ⬆️
privval/signer_server.go 100% <0%> (+4.34%) ⬆️

Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@melekes melekes merged commit 2e39418 into tendermint:master Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants