Skip to content

ValidateBasic tests#3879

Merged
melekes merged 33 commits intotendermint:masterfrom
PSalant726:validatebasic-tests
Aug 11, 2019
Merged

ValidateBasic tests#3879
melekes merged 33 commits intotendermint:masterfrom
PSalant726:validatebasic-tests

Conversation

@PSalant726
Copy link
Contributor

  • Referenced an issue explaining the need for the change
  • Wrote tests

Fixes #2740

@PSalant726 PSalant726 changed the title Validatebasic tests ValidateBasic tests Aug 4, 2019
@codecov-io
Copy link

codecov-io commented Aug 4, 2019

Codecov Report

Merging #3879 into master will increase coverage by 0.76%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3879      +/-   ##
==========================================
+ Coverage   64.91%   65.67%   +0.76%     
==========================================
  Files         217      217              
  Lines       18194    18211      +17     
==========================================
+ Hits        11810    11960     +150     
+ Misses       5463     5384      -79     
+ Partials      921      867      -54
Impacted Files Coverage Δ
blockchain/v0/pool.go 80.65% <0%> (-0.33%) ⬇️
consensus/state.go 79.95% <0%> (-0.24%) ⬇️
p2p/errors.go 20.33% <0%> (+1.29%) ⬆️
p2p/pex/pex_reactor.go 84.34% <0%> (+1.73%) ⬆️
blockchain/v1/reactor.go 81.49% <0%> (+4.27%) ⬆️
blockchain/v0/reactor.go 78.77% <0%> (+5.66%) ⬆️
consensus/reactor.go 77.96% <0%> (+6.91%) ⬆️
config/config.go 84.43% <0%> (+17.96%) ⬆️

@PSalant726 PSalant726 marked this pull request as ready for review August 5, 2019 02:36
@tac0turtle tac0turtle added ready-for-review T:test Type: Tests that need love labels Aug 5, 2019
Copy link
Contributor

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡️

Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@melekes melekes self-requested a review August 5, 2019 15:28
@PSalant726
Copy link
Contributor Author

It looks like the failing tests are unrelated to the changes in this PR. I cannot restart the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T:test Type: Tests that need love

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Write more tests for ValidateBasic methods

5 participants