Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3879 +/- ##
==========================================
+ Coverage 64.91% 65.67% +0.76%
==========================================
Files 217 217
Lines 18194 18211 +17
==========================================
+ Hits 11810 11960 +150
+ Misses 5463 5384 -79
+ Partials 921 867 -54
|
golangcibot
reviewed
Aug 4, 2019
tac0turtle
reviewed
Aug 5, 2019
Co-Authored-By: Marko <marbar3778@yahoo.com>
melekes
reviewed
Aug 5, 2019
golangcibot
reviewed
Aug 7, 2019
Contributor
Author
|
It looks like the failing tests are unrelated to the changes in this PR. I cannot restart the build. |
melekes
approved these changes
Aug 11, 2019
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2740