mempool: make max_tx_bytes configurable instead of max_msg_bytes#3877
Merged
melekes merged 4 commits intotendermint:masterfrom Aug 5, 2019
Merged
mempool: make max_tx_bytes configurable instead of max_msg_bytes#3877melekes merged 4 commits intotendermint:masterfrom
max_tx_bytes configurable instead of max_msg_bytes#3877melekes merged 4 commits intotendermint:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3877 +/- ##
==========================================
+ Coverage 66% 66.08% +0.08%
==========================================
Files 234 234
Lines 20280 20240 -40
==========================================
- Hits 13385 13375 -10
+ Misses 5845 5824 -21
+ Partials 1050 1041 -9
|
melekes
reviewed
Aug 5, 2019
config/toml.go
Outdated
|
|
||
| # Limit the size of TxMessage | ||
| max_msg_bytes = {{ .Mempool.MaxMsgBytes }} | ||
| # Limit the size of Tx |
Contributor
There was a problem hiding this comment.
Suggested change
| # Limit the size of Tx | |
| # Maximum size of a single transaction. |
config/toml.go
Outdated
| # Limit the size of TxMessage | ||
| max_msg_bytes = {{ .Mempool.MaxMsgBytes }} | ||
| # Limit the size of Tx | ||
| # NOTE: the limit size of TxMessage is this value plus amino overhead(8byte) |
Contributor
There was a problem hiding this comment.
Suggested change
| # NOTE: the limit size of TxMessage is this value plus amino overhead(8byte) | |
| # NOTE: the max size of a tx transmitted over the network is {max_tx_bytes} + {amino overhead}. |
Contributor
Author
|
Thanks for your review. |
melekes
approved these changes
Aug 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3868 (comment)