Skip to content

config: move max_msg_bytes into mempool section#3869

Merged
melekes merged 3 commits intomasterfrom
3868-config
Aug 2, 2019
Merged

config: move max_msg_bytes into mempool section#3869
melekes merged 3 commits intomasterfrom
3868-config

Conversation

@melekes
Copy link
Contributor

@melekes melekes commented Aug 2, 2019

It was incorrectly placed in fastsync section during
4d7cd80#diff-092cdc48047eeb4c0bca311a2e1b8ae6
merge.

Fixes #3868

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

It was incorrectly placed in fastsync section during
4d7cd80#diff-092cdc48047eeb4c0bca311a2e1b8ae6
merge.

Fixes #3868
@melekes melekes requested review from ebuchman and xla as code owners August 2, 2019 05:51
@melekes melekes self-assigned this Aug 2, 2019
@codecov-io
Copy link

codecov-io commented Aug 2, 2019

Codecov Report

Merging #3869 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3869      +/-   ##
==========================================
- Coverage   66.15%   66.06%   -0.09%     
==========================================
  Files         234      234              
  Lines       20287    20285       -2     
==========================================
- Hits        13420    13401      -19     
- Misses       5826     5836      +10     
- Partials     1041     1048       +7
Impacted Files Coverage Δ
config/toml.go 65.95% <ø> (ø) ⬆️
privval/socket_listeners.go 86.2% <0%> (-3.45%) ⬇️
consensus/reactor.go 71.04% <0%> (-1.88%) ⬇️
blockchain/v0/reactor.go 73.11% <0%> (-0.95%) ⬇️
consensus/replay.go 70.96% <0%> (-0.81%) ⬇️
consensus/state.go 79.95% <0%> (-0.24%) ⬇️
privval/signer_validator_endpoint.go 85.55% <0%> (ø) ⬆️
blockchain/v1/reactor.go 77.58% <0%> (+0.35%) ⬆️
p2p/pex/pex_reactor.go 83.76% <0%> (+1.15%) ⬆️
behaviour/peer_behaviour.go 100% <0%> (+25%) ⬆️

@melekes melekes merged commit f5b116c into master Aug 2, 2019
@melekes melekes deleted the 3868-config branch August 2, 2019 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mempool.MaxMsgBytes is in wrong position in config/toml.go

3 participants