Skip to content

Minor cleanup of libs#3794

Merged
melekes merged 4 commits intomasterfrom
marko/cleanup_more_libs
Jul 14, 2019
Merged

Minor cleanup of libs#3794
melekes merged 4 commits intomasterfrom
marko/cleanup_more_libs

Conversation

@tac0turtle
Copy link
Contributor

@tac0turtle tac0turtle commented Jul 13, 2019

Deleted old and unneeded code

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

@tac0turtle tac0turtle requested review from liamsi and melekes July 13, 2019 08:27
@tac0turtle tac0turtle requested review from ebuchman and xla as code owners July 13, 2019 08:27
@codecov-io
Copy link

codecov-io commented Jul 13, 2019 •
edited
Loading

Codecov Report

Merging #3794 into master will increase coverage by 0.71%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3794      +/-   ##
==========================================
+ Coverage   64.26%   64.97%   +0.71%     
==========================================
  Files         214      216       +2     
  Lines       17998    17495     -503     
==========================================
- Hits        11566    11368     -198     
+ Misses       5455     5185     -270     
+ Partials      977      942      -35
Impacted Files Coverage Δ
p2p/pex/errors.go 12.5% <0%> (-12.5%) ⬇️
privval/signer_service_endpoint.go 83.63% <0%> (-5.46%) ⬇️
privval/file.go 76.28% <0%> (-1.74%) ⬇️
p2p/pex/pex_reactor.go 83.13% <0%> (-1.17%) ⬇️
p2p/pex/addrbook.go 67.83% <0%> (-0.51%) ⬇️
blockchain/reactor.go 71.49% <0%> (ø) ⬆️
rpc/lib/server/http_params.go
rpc/lib/client/http_client.go
rpc/lib/server/handlers.go
rpc/lib/server/http_server.go
... and 20 more

melekes
melekes reviewed Jul 13, 2019
View reviewed changes
melekes
melekes reviewed Jul 13, 2019
View reviewed changes
tac0turtle and others added 2 commits July 13, 2019 13:32
@tac0turtle @melekes
Update types/vote_set_test.go
a3f55ec 
Co-Authored-By: Anton Kaliaev <anton.kalyaev@gmail.com>
@tac0turtle
spelling change
1a18d7e
melekes
melekes approved these changes Jul 14, 2019
View reviewed changes
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐈

@melekes melekes merged commit e0b9298 into master Jul 14, 2019
@melekes melekes deleted the marko/cleanup_more_libs branch July 14, 2019 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liamsi liamsi Awaiting requested review from liamsi

@ebuchman ebuchman Awaiting requested review from ebuchman

@xla xla Awaiting requested review from xla

1 more reviewer

@melekes melekes melekes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tac0turtle @codecov-io @melekes