Skip to content

tm-monitor: Add Context to RPC handlers#3792

Merged
melekes merged 6 commits intotendermint:masterfrom
sabau:1937-tm-monitor-rpc
Jul 13, 2019
Merged

tm-monitor: Add Context to RPC handlers#3792
melekes merged 6 commits intotendermint:masterfrom
sabau:1937-tm-monitor-rpc

Conversation

@sabau
Copy link
Contributor

@sabau sabau commented Jul 12, 2019 •
edited
Loading

Add Context in NewRPCFunc tm-monitor routes callbacks

Locally solves: #3791
But does not guarantee e.(error) is always an error in other places

rpc.NewRPCFunc callbacks now accept rpctypes.Context as first parameter.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

@sabau
Fix rpc handle for tm-monitor
8faefd9 
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
@sabau sabau requested review from ebuchman, melekes and xla as code owners July 12, 2019 15:21
golangcibot
golangcibot reviewed Jul 12, 2019
View reviewed changes
@codecov-io
Copy link

codecov-io commented Jul 12, 2019 •
edited
Loading

Codecov Report

Merging #3792 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3792      +/-   ##
==========================================
- Coverage   64.34%   64.27%   -0.08%     
==========================================
  Files         214      214              
  Lines       18010    18010              
==========================================
- Hits        11589    11576      -13     
- Misses       5449     5458       +9     
- Partials      972      976       +4
Impacted Files Coverage Δ
privval/signer_validator_endpoint.go 75.55% <0%> (-10%) ⬇️
blockchain/reactor.go 70.56% <0%> (-3.74%) ⬇️
privval/socket_listeners.go 86.2% <0%> (-3.45%) ⬇️
privval/signer_remote.go 80% <0%> (-2%) ⬇️
blockchain/pool.go 80.26% <0%> (-1.98%) ⬇️
consensus/state.go 79.97% <0%> (+0.23%) ⬆️
p2p/conn/connection.go 80.85% <0%> (+0.26%) ⬆️
p2p/pex/pex_reactor.go 84.88% <0%> (+0.58%) ⬆️
consensus/replay.go 71.02% <0%> (+0.81%) ⬆️
consensus/reactor.go 72.21% <0%> (+0.82%) ⬆️

@sabau
go imports file
964e245 
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
golangcibot
golangcibot reviewed Jul 12, 2019
View reviewed changes
sabau and others added 3 commits July 12, 2019 18:06
@sabau
go imports file
096253e 
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
@sabau
fix RPCUnmonitor too
1d767ee 
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
@melekes
Merge branch 'master' into 1937-tm-monitor-rpc
0e67eea
melekes
melekes approved these changes Jul 13, 2019
View reviewed changes
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@melekes melekes merged commit 78e634d into tendermint:master Jul 13, 2019
@sabau sabau deleted the 1937-tm-monitor-rpc branch July 14, 2019 17:22
@melekes melekes mentioned this pull request Jul 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebuchman ebuchman Awaiting requested review from ebuchman

@xla xla Awaiting requested review from xla

2 more reviewers

@golangcibot golangcibot golangcibot left review comments

@melekes melekes melekes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sabau @codecov-io @melekes @golangcibot