Skip to content

Clean up fail.go#3785

Merged
melekes merged 3 commits intomasterfrom
marko/cleanup_fail.go
Jul 14, 2019
Merged

Clean up fail.go#3785
melekes merged 3 commits intomasterfrom
marko/cleanup_fail.go

Conversation

@tac0turtle
Copy link
Contributor

  • Clean up fail.go
  • Remove unneeded Func FailRand()

closes #2729

Signed-off-by: Marko Baricevic marbar3778@yahoo.com

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

- Clean up fail.go
- Remove unneeded Func `FailRand()`

closes #2729

Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
@tac0turtle tac0turtle requested review from ebuchman and xla as code owners July 10, 2019 15:00
@tac0turtle tac0turtle added T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. ready-for-review labels Jul 10, 2019
@codecov-io
Copy link

codecov-io commented Jul 13, 2019

Codecov Report

Merging #3785 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3785      +/-   ##
==========================================
- Coverage    64.3%   64.14%   -0.16%     
==========================================
  Files         214      214              
  Lines       17978    18010      +32     
==========================================
- Hits        11561    11553       -8     
- Misses       5448     5475      +27     
- Partials      969      982      +13
Impacted Files Coverage Δ
privval/signer_service_endpoint.go 80% <0%> (-5.46%) ⬇️
consensus/ticker.go 91.66% <0%> (-4.17%) ⬇️
consensus/reactor.go 70.45% <0%> (-2.94%) ⬇️
privval/signer_remote.go 78% <0%> (-2%) ⬇️
consensus/state.go 79.73% <0%> (-0.83%) ⬇️
consensus/replay.go 71.02% <0%> (+0.81%) ⬆️
p2p/pex/pex_reactor.go 84.88% <0%> (+1.74%) ⬆️
p2p/key.go 70.21% <0%> (+3.54%) ⬆️

Copy link
Contributor

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@melekes melekes merged commit 5d1459b into master Jul 14, 2019
@melekes melekes deleted the marko/cleanup_fail.go branch July 14, 2019 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup libs/fail

4 participants