Skip to content

Quick link fixes throughout docs and repo#3776

Merged
melekes merged 7 commits intomasterfrom
marko/link_fixes
Jul 8, 2019
Merged

Quick link fixes throughout docs and repo#3776
melekes merged 7 commits intomasterfrom
marko/link_fixes

Conversation

@tac0turtle
Copy link
Contributor

  • used markdown link tester to find broken links

Signed-off-by: Marko Baricevic marbar3778@yahoo.com

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

- used markdown link tester to find broken links

Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
@codecov-io
Copy link

codecov-io commented Jul 8, 2019

Codecov Report

Merging #3776 into master will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3776      +/-   ##
==========================================
+ Coverage   63.88%   63.92%   +0.04%     
==========================================
  Files         217      217              
  Lines       18140    18100      -40     
==========================================
- Hits        11589    11571      -18     
+ Misses       5573     5551      -22     
  Partials      978      978
Impacted Files Coverage Δ
libs/db/remotedb/remotedb.go 35.89% <0%> (-4.94%) ⬇️
privval/signer_remote.go 80% <0%> (-2%) ⬇️
blockchain/pool.go 79.93% <0%> (-0.33%) ⬇️
libs/db/remotedb/grpcdb/client.go 0% <0%> (ø) ⬆️
p2p/pex/pex_reactor.go 82.67% <0%> (+0.56%) ⬆️
libs/clist/clist.go 68.18% <0%> (+1.51%) ⬆️
privval/signer_service_endpoint.go 85.45% <0%> (+1.81%) ⬆️

Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this ❤️


There is a CircleCI job listening for changes in the `/docs` directory, on both
the `master` and `develop` branches. Any updates to files in this directory
the `master` branch. Any updates to files in this directory
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 gone

Copy link
Contributor

@sabau sabau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So many links fixed! nice work

Tendermint Core is Byzantine Fault Tolerant (BFT) middleware that takes a state transition machine, written in any programming language, and securely replicates it on many machines.

For more background, see the [introduction](https://tendermint.readthedocs.io/en/master/introduction.html).
For more background, see the [the docs](https://tendermint.com/docs/introduction/#quick-start).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just asking, the en is no more supported or was the only available language?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copied the link from online, doesn't seem the multiple langs are supported anymore

@melekes melekes merged commit f2ada0a into master Jul 8, 2019
@melekes melekes deleted the marko/link_fixes branch July 8, 2019 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants