Skip to content

rpc: make possible to set absolute paths for TLS cert and key#3765

Merged
melekes merged 1 commit intotendermint:masterfrom
climber73:3700-abs-paths-for-tls-files
Jul 1, 2019
Merged

rpc: make possible to set absolute paths for TLS cert and key#3765
melekes merged 1 commit intotendermint:masterfrom
climber73:3700-abs-paths-for-tls-files

Conversation

@climber73
Copy link
Contributor

@climber73 climber73 commented Jun 30, 2019

Resolve #3700

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@d4cf204). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #3765   +/-   ##
=========================================
  Coverage          ?   63.99%           
=========================================
  Files             ?      217           
  Lines             ?    18121           
  Branches          ?        0           
=========================================
  Hits              ?    11597           
  Misses            ?     5550           
  Partials          ?      974
Impacted Files Coverage Δ
config/toml.go 65.95% <ø> (ø)
config/config.go 67.53% <100%> (ø)

Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

Very nice PR!

@melekes melekes merged commit d9481e3 into tendermint:master Jul 1, 2019
@climber73 climber73 deleted the 3700-abs-paths-for-tls-files branch July 1, 2019 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Absolute paths for TLS cert and key does not work

3 participants