p2p: Per channel metrics (#3666)#3677
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3677 +/- ##
===========================================
+ Coverage 63.3% 63.44% +0.13%
===========================================
Files 218 218
Lines 18208 18168 -40
===========================================
- Hits 11527 11526 -1
+ Misses 5717 5674 -43
- Partials 964 968 +4
|
ebuchman
left a comment
There was a problem hiding this comment.
Awesome thanks - should this be considered a breaking change? Ie. will anyones current setup break with this change, or does it just add new/more info ?
This should be a non breaking changing. The only concern which might be worth noting is this will create additional metrics and increased data for prometheus server pulling the data in. So long as the peer set is bounded and has low churn, This shouldn't be too big a deal. |
not the case for seed nodes |
|
Would it be something in the region of: |
xla
left a comment
There was a problem hiding this comment.
Extra dope
👍 
💃
The cardinality concern is valid, but we should be safe.
Reactors run in parallel exchanging messages with peers across channels. To understand the behaviour of the system as a whole, it would be helpful that have visibility into the per channel (and thus per reactor) message exchange. With per channel metrics, we can observe when a given reactor has stopped sending/receiving and correlate cpu usage with potential thread saturation.
Cf. #3666