[p2p] Peer behaviour test tweaks#3662
Merged
ebuchman merged 3 commits intotendermint:developfrom May 27, 2019
Merged
Conversation
Address the remaining test issues mentioned in #tendermint#3552 notably: + switch to p2p_test package + Use `Error` instead of `Errorf` when not using formatting + Add expected/got errors to `TestMockPeerBehaviourReporterConcurrency` test
+ slices of PeerBehaviours should be compared as histograms to
ensure they have the same set of PeerBehaviours at the same
freequncy.
Codecov Report
@@ Coverage Diff @@
## develop #3662 +/- ##
===========================================
- Coverage 63.18% 63.17% -0.01%
===========================================
Files 218 218
Lines 18194 18200 +6
===========================================
+ Hits 11496 11498 +2
- Misses 5727 5732 +5
+ Partials 971 970 -1
|
+ Add tests for the equivalence between sets of PeerBehaviours
ebuchman
approved these changes
May 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Peer behaviour test tweaks towards #3653.
Address the remaining test issues mentioned in #3552 notably:
Errorinstead ofErrorfwhen not using formattingTestMockPeerBehaviourReporterConcurrencytestAlso addresses a bug in
equalBehavioursin which only the lengths of the behaviours was being tested and not the actual contents.