Skip to content

Update release/v0.31.1 to include #3488#3491

Merged
melekes merged 2 commits intorelease/v0.31.1from
updated-release/v0.31.1
Mar 27, 2019
Merged

Update release/v0.31.1 to include #3488#3491
melekes merged 2 commits intorelease/v0.31.1from
updated-release/v0.31.1

Conversation

@liamsi
Copy link
Contributor

@liamsi liamsi commented Mar 27, 2019

Do not squash to include commit: 6a45379

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

brapse and others added 2 commits March 27, 2019 19:09
* docs: fix broken links (#3482)

A bunch of links were broken in the documentation s they included the
`docs` prefix.

* Update CHANGELOG_PENDING

* docs: switch to relative links for github compatitibility (#3482)
@liamsi liamsi requested review from ebuchman, melekes and xla as code owners March 27, 2019 18:13
@codecov-io
Copy link

Codecov Report

Merging #3491 into release/v0.31.1 will increase coverage by 0.06%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##           release/v0.31.1    #3491      +/-   ##
===================================================
+ Coverage            64.14%   64.21%   +0.06%     
===================================================
  Files                  213      213              
  Lines                17508    17508              
===================================================
+ Hits                 11231    11243      +12     
+ Misses                5333     5322      -11     
+ Partials               944      943       -1
Impacted Files Coverage Δ
privval/signer_remote.go 80% <0%> (-2%) ⬇️
consensus/reactor.go 71.9% <0%> (+1.29%) ⬆️
privval/signer_service_endpoint.go 89.09% <0%> (+5.45%) ⬆️

@liamsi
Copy link
Contributor Author

liamsi commented Mar 27, 2019

Thanks @melekes! I can merge to develop now but I can't to the release branch:
image

@melekes melekes merged commit a49d80b into release/v0.31.1 Mar 27, 2019
@melekes melekes deleted the updated-release/v0.31.1 branch March 27, 2019 22:15
@liamsi liamsi mentioned this pull request Mar 28, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants