Skip to content

fix issue3460#3465

Closed
Zerppen wants to merge 4 commits intotendermint:developfrom
Zerppen:zerppen
Closed

fix issue3460#3465
Zerppen wants to merge 4 commits intotendermint:developfrom
Zerppen:zerppen

Conversation

@Zerppen
Copy link

@Zerppen Zerppen commented Mar 21, 2019 •
edited
Loading

When replaying blocks we should check apphash,however current logic will result in replaying too many wrong blocks if current block's apphash is wrong.
To solve this problem,check each block's appash is import and necessary .

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

@Zerppen
Copy link
Author

Zerppen commented Mar 21, 2019

@melekes hi melekes,I'm sorry for disturbing you .
Can you give me you email for more contribution.

@Zerppen
Copy link
Author

Zerppen commented Mar 21, 2019

@melekes Hi,I don't know this result of "ci/circleci: test_cover".Can you do me a faver.

@liamsi liamsi mentioned this pull request Mar 21, 2019
Closed
4 tasks
@liamsi
Copy link
Contributor

liamsi commented Mar 21, 2019

Looks like the pull request is created from a very old version of the software. I'm not sure why there aren't more changes showing up on github but:
image

I checked out the PR locally and I can confirm that there are many errors like:

../proxy/app_conn.go:4:2: cannot find package "github.com/tendermint/abci/client" in any of:
	/Users/ismail/go/src/github.com/tendermint/tendermint/vendor/github.com/tendermint/abci/client (vendor tree)
	/usr/local/Cellar/go/1.12.1/libexec/src/github.com/tendermint/abci/client (from $GOROOT)
	/Users/ismail/go/src/github.com/tendermint/abci/client (from $GOPATH)

@Zerppen
Copy link
Author

Zerppen commented Mar 22, 2019

@liamsi yeah,this version I cloned one year ago.I will open another PR.

@Zerppen Zerppen closed this Mar 22, 2019
@liamsi liamsi mentioned this pull request Mar 23, 2019
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebuchman ebuchman Awaiting requested review from ebuchman

@melekes melekes Awaiting requested review from melekes

@xla xla Awaiting requested review from xla

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Zerppen @liamsi