Merged
Conversation
Contributor
ebuchman
commented
Dec 23, 2016
- More tests:
- Crash all nodes in net and restart them (p2p crash all nodes test #339)
- Crash a single node at pre-defined break points and restart
- replace AppHashIsStale by saving an IntermediateState
Error #1: ``` Error response from daemon: network with name local_testnet already exists ``` Fixed by stopping and removing local_testnet containers and removing the network Error #2: ``` docker: Error response from daemon: Conflict. The name "/test_container_basic" is already in use by container a7cd15d479a964675e7f259de4ed852e7dfef85b447514728f437cd0b980a709. You have to remove (or rename) that container to beable to reuse that name.. ``` Fixed by adding `--rm` flag.
Current coverage is 49.59% (diff: 47.61%)
|
b127c99 to
0085a73
Compare
0085a73 to
bd222d6
Compare
jaekwon
approved these changes
Jan 6, 2017
consensus/state.go
Outdated
| // let's go for it anyways, maybe we're fine | ||
| } | ||
|
|
||
| // If the latest block was applied in the tmsp handshake, |
Contributor
There was a problem hiding this comment.
The only time we don’t write the current #height to the wal should be if we saved a new block, then called ApplyBlock on it, and failed to complete updateToState(), right?
In state/execution.go, if h.state.LastBlockHeight == appBlockHeight, store is ahead of app but core's state height is at apps height.
... then we apply the block… but maybe we shouldn’t be doing that. That seems like something the cs.wal should complete
Contributor
Author
There was a problem hiding this comment.
yep, we want the cswal to actually handle all the cases: #352
This was referenced Jan 11, 2017
Closed
faddat
referenced
this pull request
in notional-labs/tendermint
Apr 3, 2023
Signed-off-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Lasaro <lasaro@informal.systems>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.