Merged
Conversation
Contributor
ebuchman
commented
Dec 21, 2018
- Updated all relevant documentation in docs
- Updated all code comments where relevant
- Wrote tests
- Updated CHANGELOG_PENDING.md
because we pop txs from the front if the cache is full Refs #3035
liamsi
approved these changes
Dec 21, 2018
Codecov Report
@@ Coverage Diff @@
## master #3062 +/- ##
==========================================
- Coverage 62.9% 62.86% -0.04%
==========================================
Files 212 212
Lines 17394 17405 +11
==========================================
+ Hits 10941 10942 +1
- Misses 5533 5543 +10
Partials 920 920
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.