types: NewValidatorSet doesn't panic on empty valz list#2938
Merged
types: NewValidatorSet doesn't panic on empty valz list#2938
Conversation
ValarDragon
approved these changes
Nov 28, 2018
Contributor
ValarDragon
left a comment
There was a problem hiding this comment.
🌠
needs changelog entry though
Codecov Report
@@ Coverage Diff @@
## develop #2938 +/- ##
===========================================
- Coverage 62.69% 62.65% -0.04%
===========================================
Files 212 212
Lines 17327 17327
===========================================
- Hits 10863 10857 -6
- Misses 5552 5556 +4
- Partials 912 914 +2
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes regression in v0.26.4 #2937
We should backport this to v0.26.5 as well.
We should also write a test for the case where the genesis has no validators (allowed, since they can be set by InitChain), since this is what the SDK and more advanced apps will do ...