Skip to content

Optimize: using parameters in func#2845

Merged
melekes merged 1 commit intotendermint:developfrom
withzoo:optimize
Nov 15, 2018
Merged

Optimize: using parameters in func#2845
melekes merged 1 commit intotendermint:developfrom
withzoo:optimize

Conversation

@withzoo
Copy link
Contributor

@withzoo withzoo commented Nov 15, 2018

Signed-off-by: Zeyu Zhu zhuzeyu0409@gmail.com

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

Signed-off-by: Zeyu Zhu <zhuzeyu0409@gmail.com>
@withzoo withzoo changed the title Remove unnecessary parameters Optimize: using parameters in func Nov 15, 2018
@codecov-io
Copy link

Codecov Report

Merging #2845 into develop will decrease coverage by 0.03%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #2845      +/-   ##
===========================================
- Coverage    62.23%   62.19%   -0.04%     
===========================================
  Files          212      212              
  Lines        17255    17266      +11     
===========================================
  Hits         10738    10738              
- Misses        5614     5622       +8     
- Partials       903      906       +3
Impacted Files Coverage Δ
state/store.go 70.07% <100%> (ø) ⬆️
privval/ipc_server.go 64.15% <0%> (-5.67%) ⬇️
privval/tcp_server.go 78.57% <0%> (-2.86%) ⬇️
consensus/reactor.go 67.2% <0%> (-0.47%) ⬇️
consensus/wal_generator.go 79.43% <0%> (+0.27%) ⬆️

Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find @zhuzeyu 👍

@melekes melekes merged commit a70a532 into tendermint:develop Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants