Skip to content

docs: update genesis info#2831

Merged
melekes merged 1 commit intodevelopfrom
zach/genesis
Nov 14, 2018
Merged

docs: update genesis info#2831
melekes merged 1 commit intodevelopfrom
zach/genesis

Conversation

@zramsay
Copy link
Contributor

@zramsay zramsay commented Nov 13, 2018

closes #2814

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

@codecov-io
Copy link

Codecov Report

Merging #2831 into develop will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2831      +/-   ##
===========================================
+ Coverage    62.25%   62.28%   +0.03%     
===========================================
  Files          212      212              
  Lines        17253    17244       -9     
===========================================
+ Hits         10740    10741       +1     
+ Misses        5610     5602       -8     
+ Partials       903      901       -2
Impacted Files Coverage Δ
privval/tcp_server.go 78.57% <0%> (-2.86%) ⬇️
consensus/state.go 80.02% <0%> (+0.23%) ⬆️
consensus/reactor.go 68.59% <0%> (+0.92%) ⬆️
privval/tcp_socket.go 100% <0%> (+8%) ⬆️

Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@melekes melekes merged commit 27fcf96 into develop Nov 14, 2018
@melekes melekes deleted the zach/genesis branch November 14, 2018 10:34
@melekes
Copy link
Contributor

melekes commented Nov 14, 2018

We also need to document ConsensusParams in https://tendermint.com/docs/tendermint-core/using-tendermint.html#fields.

@zramsay
Copy link
Contributor Author

zramsay commented Nov 14, 2018

#2836

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants