Skip to content

cleanup ecosystem#2829

Merged
melekes merged 1 commit intodevelopfrom
update-ecosystem
Nov 14, 2018
Merged

cleanup ecosystem#2829
melekes merged 1 commit intodevelopfrom
update-ecosystem

Conversation

@zramsay
Copy link
Contributor

@zramsay zramsay commented Nov 13, 2018

closes #2777

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

@codecov-io
Copy link

Codecov Report

Merging #2829 into develop will increase coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2829      +/-   ##
===========================================
+ Coverage    62.25%   62.29%   +0.04%     
===========================================
  Files          212      212              
  Lines        17253    17219      -34     
===========================================
- Hits         10740    10726      -14     
+ Misses        5610     5592      -18     
+ Partials       903      901       -2
Impacted Files Coverage Δ
privval/tcp_server.go 78.57% <0%> (-2.86%) ⬇️
privval/ipc_server.go 67.92% <0%> (-1.89%) ⬇️
rpc/client/httpclient.go 68.78% <0%> (-0.98%) ⬇️
consensus/reactor.go 67.44% <0%> (-0.23%) ⬇️
rpc/core/mempool.go 0% <0%> (ø) ⬆️
libs/pubsub/pubsub.go 83.89% <0%> (ø) ⬆️
rpc/core/consensus.go 0% <0%> (ø) ⬆️
p2p/pex/addrbook.go 68.91% <0%> (ø) ⬆️
mempool/reactor.go 64.19% <0%> (ø) ⬆️
consensus/state.go 79.78% <0%> (ø) ⬆️
... and 4 more

Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥑

@melekes melekes merged commit 3af11c4 into develop Nov 14, 2018
@melekes melekes deleted the update-ecosystem branch November 14, 2018 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants