Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2822 +/- ##
===========================================
- Coverage 62.51% 62.31% -0.21%
===========================================
Files 212 212
Lines 17168 17206 +38
===========================================
- Hits 10733 10722 -11
- Misses 5539 5584 +45
- Partials 896 900 +4
|
ValarDragon
reviewed
Nov 12, 2018
|
|
||
| [[constraint]] | ||
| name = "github.com/tendermint/go-amino" | ||
| version = "v0.14.0" |
Contributor
There was a problem hiding this comment.
I find it kind of weird that this now break dependencies for any downstream application who was still using v0.14.0. perhaps we should set it to allow v0.14.0 and v0.14.1, and then the downstream rasp-pi app would just select v0.14.1?
Contributor
There was a problem hiding this comment.
Doesn't block merge, but is a general note about dependencies
Contributor
There was a problem hiding this comment.
Yeah, I think we should switch to ^X.Y.Z or ~X.Y.Z for most of the dependencies.
liamsi
approved these changes
Nov 12, 2018
Contributor
|
Can you redo this using |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes int overflow that prevent
tendermintfrom building on RPi