Enforce validators can only use the correct pubkey type#2739
Merged
Enforce validators can only use the correct pubkey type#2739
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2739 +/- ##
===========================================
+ Coverage 62.68% 62.68% +<.01%
===========================================
Files 212 212
Lines 17305 17327 +22
===========================================
+ Hits 10847 10862 +15
- Misses 5548 5552 +4
- Partials 910 913 +3
|
dced7f8 to
4c62d24
Compare
Contributor
Author
|
I'm kind of confused about the pre-existing situation about how errors are handled in execution.go. If one validator update fails, won't all subsequent validator updates fail? Really we just want that one update to fail. I think that issue is distinct from this one (i.e. shouldn't block this PR), though I am still confused by it. |
ebuchman
reviewed
Nov 6, 2018
docs/spec/blockchain/state.md
Outdated
| @@ -85,6 +85,7 @@ type ConsensusParams struct { | |||
| TxSize | |||
Contributor
There was a problem hiding this comment.
Oh damn, this needs to be updated - TxSize and BlockGossip were removed!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit on this branch mirrors #2714 before the commit chaos happened.
What remains to be done: