Skip to content

one less dependency#2728

Merged
ebuchman merged 1 commit intodevelopfrom
zach/fail-test
Oct 30, 2018
Merged

one less dependency#2728
ebuchman merged 1 commit intodevelopfrom
zach/fail-test

Conversation

@zramsay
Copy link
Contributor

@zramsay zramsay commented Oct 29, 2018

closes #2638

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍓 🍌 🥛

"strconv"
)

var callIndexToFail int
Copy link
Contributor

@melekes melekes Oct 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: we should probably rewrite this to avoid callIndexToFail and other global variables being included in the runtime

Copy link
Contributor

@ebuchman ebuchman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guys this library was my claim to fame. You really want to take that away from me ?

// FailRand should be called n successive times.
// It will fail on a random one of those calls
// n must be greater than 0
func FailRand(n int) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just get rid of this func, it's never used.

@ebuchman ebuchman merged commit cdc252b into develop Oct 30, 2018
@ebuchman ebuchman deleted the zach/fail-test branch October 30, 2018 14:34
@ebuchman ebuchman mentioned this pull request Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants