[R4R] libs/log: add year to log format#2707
Merged
ebuchman merged 2 commits intotendermint:developfrom Oct 30, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2707 +/- ##
===========================================
- Coverage 61.72% 61.52% -0.21%
===========================================
Files 207 207
Lines 16942 16942
===========================================
- Hits 10458 10424 -34
- Misses 5622 5652 +30
- Partials 862 866 +4
|
Contributor
|
Refs #1212 |
Contributor
Author
|
I see, but it seems there is no conclusion. When can we sit down to reach an agreement and set out to do that. I can help. |
melekes
approved these changes
Oct 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to #2706, I encountered a problem about log format collecting logs to ELK stack for lacking year in timestamp.
Our log format before is:
I want to change it to
It will help a lot to analyze logs for us.