Skip to content

fix RecoverAndLogHandler not to call multiple writeheader#2688

Merged
melekes merged 1 commit intotendermint:developfrom
bluele:fix/multiple-writeheader-calls
Oct 24, 2018
Merged

fix RecoverAndLogHandler not to call multiple writeheader#2688
melekes merged 1 commit intotendermint:developfrom
bluele:fix/multiple-writeheader-calls

Conversation

@bluele
Copy link
Contributor

@bluele bluele commented Oct 22, 2018

This PR is for suppressing warning log.

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍏 Thanks

@codecov-io
Copy link

Codecov Report

Merging #2688 into develop will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2688      +/-   ##
===========================================
+ Coverage    61.56%   61.57%   +<.01%     
===========================================
  Files          207      207              
  Lines        16939    16935       -4     
===========================================
- Hits         10429    10428       -1     
+ Misses        5647     5642       -5     
- Partials       863      865       +2
Impacted Files Coverage Δ
privval/ipc_server.go 64.15% <0%> (-5.67%) ⬇️
libs/events/events.go 93.2% <0%> (-4.86%) ⬇️
blockchain/pool.go 65.73% <0%> (-0.7%) ⬇️
evidence/store.go 89.87% <0%> (-0.49%) ⬇️
p2p/pex/addrbook.go 69.58% <0%> (-0.49%) ⬇️
consensus/reactor.go 72.77% <0%> (+1.93%) ⬆️

@melekes melekes merged commit 9795e12 into tendermint:develop Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants