Set protocol versions in NodeInfo from state#2686
Merged
Conversation
melekes
approved these changes
Oct 22, 2018
Codecov Report
@@ Coverage Diff @@
## develop #2686 +/- ##
===========================================
- Coverage 61.56% 61.49% -0.08%
===========================================
Files 207 207
Lines 16939 16938 -1
===========================================
- Hits 10429 10416 -13
- Misses 5647 5654 +7
- Partials 863 868 +5
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the protocol versions in the NodeInfo from the state, not from the globals.
Also avoid use of some Validator literals