crypto: use stdlib crypto/rand. ref #2099#2669
Merged
Conversation
4 tasks
Codecov Report
@@ Coverage Diff @@
## develop #2669 +/- ##
===========================================
- Coverage 61.7% 61.53% -0.17%
===========================================
Files 207 207
Lines 16928 16923 -5
===========================================
- Hits 10445 10414 -31
- Misses 5616 5643 +27
+ Partials 867 866 -1
|
melekes
approved these changes
Oct 19, 2018
ValarDragon
reviewed
Oct 19, 2018
crypto/random.go
Outdated
| @@ -26,6 +27,7 @@ func init() { | |||
| gRandInfo.MixEntropy(randBytes(32)) // Init | |||
Contributor
There was a problem hiding this comment.
I'd prefer if we commented out this as well, to mitigate confusion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #2099