Added the marshal,unmarshal and size methods to make compatible with grpc#2660
Closed
vlasfama wants to merge 1 commit intotendermint:masterfrom
vlasfama:nagadev
Closed
Added the marshal,unmarshal and size methods to make compatible with grpc#2660vlasfama wants to merge 1 commit intotendermint:masterfrom vlasfama:nagadev
vlasfama wants to merge 1 commit intotendermint:masterfrom
vlasfama:nagadev
Conversation
Contributor
|
Contributor
|
What is the issue you're trying to solve exactly? Tendermint is using https://github.com/tendermint/go-amino to encode/decode blocks and block parts. |
Contributor
Author
|
I am using the tendermint in our project. I have to get the blockmeta details and block details using grpc protobuf, when i create the protobuf its asking for Marshal, unmarshal and size methods for the blockmeta and block. which was not present in tendermint. |
Contributor
You can generate these methods automatically using https://github.com/gogo/protobuf or a similar library. Not sure we need these methods in our repo. |
Contributor
Author
|
move to #2705 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the marshal,unmarshal and size methods to make compatible with grpc protobuf
*Added the above function in blockmeta.go and block.go