Skip to content

[rpc] fix /abci_query: trusted was renamed to prove#2531

Merged
ebuchman merged 1 commit intodevelopfrom
anton/fix-abci-query
Oct 3, 2018
Merged

[rpc] fix /abci_query: trusted was renamed to prove#2531
ebuchman merged 1 commit intodevelopfrom
anton/fix-abci-query

Conversation

@melekes
Copy link
Contributor

@melekes melekes commented Oct 2, 2018

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

@melekes melekes requested review from ebuchman and xla as code owners October 2, 2018 14:23
@codecov-io
Copy link

Codecov Report

Merging #2531 into develop will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2531      +/-   ##
===========================================
+ Coverage    61.29%   61.33%   +0.03%     
===========================================
  Files          202      202              
  Lines        16720    16731      +11     
===========================================
+ Hits         10249    10262      +13     
- Misses        5602     5603       +1     
+ Partials       869      866       -3
Impacted Files Coverage Δ
rpc/core/routes.go 0% <ø> (ø) ⬆️
consensus/reactor.go 72.99% <0%> (-0.13%) ⬇️
consensus/state.go 77.65% <0%> (+0.35%) ⬆️
evidence/store.go 90.36% <0%> (+1.47%) ⬆️


// abci API
"abci_query": rpc.NewRPCFunc(ABCIQuery, "path,data,height,trusted"),
"abci_query": rpc.NewRPCFunc(ABCIQuery, "path,data,height,prove"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching this

@ebuchman ebuchman merged commit f3d08f9 into develop Oct 3, 2018
@ebuchman ebuchman deleted the anton/fix-abci-query branch October 3, 2018 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants