Skip to content

Make block_test.go more table driven#2526

Merged
melekes merged 1 commit intodevelopfrom
dev/improve_tests
Oct 2, 2018
Merged

Make block_test.go more table driven#2526
melekes merged 1 commit intodevelopfrom
dev/improve_tests

Conversation

@ValarDragon
Copy link
Contributor

  • Wrote tests

@codecov-io
Copy link

Codecov Report

Merging #2526 into develop will decrease coverage by 0.14%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2526      +/-   ##
===========================================
- Coverage    61.47%   61.33%   -0.15%     
===========================================
  Files          202      202              
  Lines        16668    16668              
===========================================
- Hits         10247    10223      -24     
- Misses        5556     5583      +27     
+ Partials       865      862       -3
Impacted Files Coverage Δ
libs/db/remotedb/remotedb.go 36.84% <0%> (-4.69%) ⬇️
consensus/reactor.go 72.6% <0%> (-0.78%) ⬇️
libs/clist/clist.go 66.49% <0%> (-0.17%) ⬇️
privval/priv_validator.go 71.02% <0%> (ø) ⬆️
libs/db/remotedb/grpcdb/server.go 0% <0%> (ø) ⬆️
config/toml.go 53.19% <0%> (ø) ⬆️
node/node.go 65.65% <0%> (ø) ⬆️
config/config.go 69.23% <0%> (+0.12%) ⬆️
p2p/conn/connection.go 79.71% <0%> (+0.28%) ⬆️
mempool/mempool.go 74.63% <0%> (+0.73%) ⬆️

Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰 🌮 🍉

Great PR!

@melekes melekes merged commit fd1b859 into develop Oct 2, 2018
@melekes melekes deleted the dev/improve_tests branch October 2, 2018 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants