@jaekwon @mossid not 100% sure where the KeyPath stuff interfaces with the user. Are we expecting that the KeyPath passed into RequestQuery.Path corresponds to the keys in the ResponseQuery.Proofs? In which case this KeyPath becomes the sort of standard for RequestQuery.Path and should also be documented here?

Noting that it's a bit weird for the general Merkle proof types to live in crypto/merkle. They're effectively part of ABCI and should live in abci/types, just like the ABCI PubKey type...

We would also benefit from separation in crypto/merkle between the SimpleTree code and the GeneralMerkle code. Since we want most of the crypto/merkle to be used by external consumers, it really helps to have separation to simplify looking at the godoc.org.

Codecov Report

Merging #2524 into develop will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2524      +/-   ##
===========================================
- Coverage    61.35%   61.32%   -0.03%     
===========================================
  Files          202      202              
  Lines        16668    16710      +42     
===========================================
+ Hits         10226    10247      +21     
- Misses        5580     5598      +18     
- Partials       862      865       +3

Please review, but merging for staging deployment. Opened my comment in #2527