Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2522 +/- ##
==========================================
+ Coverage 61.31% 61.5% +0.19%
==========================================
Files 202 202
Lines 16710 16668 -42
==========================================
+ Hits 10246 10252 +6
+ Misses 5599 5553 -46
+ Partials 865 863 -2
|
|
Tested with a local vuepress build. Please review, but merging so we can see it on staging. |
| # Remote Cluster with Terraform and Ansible | ||
|
|
||
| See the [docs](/docs/terraform-and-ansible.md) | ||
| See the [docs](https://tendermint.com/docs/networks/terraform-and-ansible.html). |
There was a problem hiding this comment.
don't we want Github links to still work?
There was a problem hiding this comment.
Like we should just link to the github markdown here instead of the website docs?
There was a problem hiding this comment.
see #links in the DOCS_README
There was a problem hiding this comment.
should be relative links - they work everywhere and are permanent
|
|
||
| DEPRECATED! | ||
|
|
||
| See the [docs](https://tendermint.com/docs/networks/docker-compose.html). |
There was a problem hiding this comment.
use relative links. see DOCS_REAMDE
| @@ -0,0 +1,15 @@ | |||
| # Introduction | |||
|
|
|||
There was a problem hiding this comment.
what's the point of this file? it isn't added to the sidebar ... (config.js didn't change in this PR)
There was a problem hiding this comment.
I like all the sections having landing pages. Is that wrong? :P
There was a problem hiding this comment.
it didn't add a landing page (except on GH) if not added to the config.js
There was a problem hiding this comment.
Sure did! https://tendermint-staging.interblock.io/docs/introduction/
But it only works with the trailing slash!
There was a problem hiding this comment.
ah, and it's only accessible from the link, there's nothing to navigate to it within the sidebar.
There was a problem hiding this comment.
Right, hence my TODO in the opening comment for this PR:
TODO: can we get the sidebar headers to be links to these?
Think that's possible?
There was a problem hiding this comment.
missed it, yup. spec has it, i'll update that.
Closes #2376 and #2378.
Small makeover/improvements to
docs:docs/introduction/introduction.md- moved tointroduction/what-is-tendermint.mddocs/networks/deploy-testnets.md- it's mostly duplication of other information and doesn't read that well. Let's encourage people to look attendermint testnet --helpand understand theTendermint Coresection instead. Otherwise replaces withdocs/networks/docker-compose.md.networks/local/README.md- moved todocs/networks/docker-compose.md