Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2516 +/- ##
===========================================
+ Coverage 61.31% 61.33% +0.01%
===========================================
Files 202 202
Lines 16710 16655 -55
===========================================
- Hits 10246 10215 -31
+ Misses 5599 5576 -23
+ Partials 865 864 -1
|
melekes
reviewed
Sep 29, 2018
evidence/store.go
Outdated
| l2 := make([]types.Evidence, len(l)) | ||
| for i := range l { | ||
| l2[i] = l[len(l)-1-i] | ||
| for i := len(l)/2 - 1; i >= 0; i-- { |
Contributor
There was a problem hiding this comment.
i, j := 0, len(l)-1; i < j; i, j = i+1, j-1 {
l[i], l[j] = l[j], l[i]
}How about ^^^?
Contributor
Author
There was a problem hiding this comment.
I think both is ok，respect your prefrence.
melekes
reviewed
Sep 29, 2018
| func (store *EvidenceStore) listEvidence(prefixKey string, maxBytes int64) (evidence []types.Evidence) { | ||
| var bytes int64 | ||
| iter := dbm.IteratePrefix(store.db, []byte(prefixKey)) | ||
| defer iter.Close() |
Contributor
There was a problem hiding this comment.
Whoops. Not sure how we missed this. Thanks for spotting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #2515