Skip to content

config: refactor ValidateBasic#2503

Merged
xla merged 3 commits intodevelopfrom
anton/config-refactor
Oct 1, 2018
Merged

config: refactor ValidateBasic#2503
xla merged 3 commits intodevelopfrom
anton/config-refactor

Conversation

@melekes
Copy link
Contributor

@melekes melekes commented Sep 28, 2018

No description provided.

@melekes melekes force-pushed the anton/config-refactor branch from 4dd07e5 to 43690e2 Compare September 28, 2018 08:33
@codecov-io
Copy link

codecov-io commented Sep 28, 2018

Codecov Report

Merging #2503 into develop will decrease coverage by <.01%.
The diff coverage is 27.27%.

@@             Coverage Diff             @@
##           develop    #2503      +/-   ##
===========================================
- Coverage    61.32%   61.32%   -0.01%     
===========================================
  Files          202      202              
  Lines        16694    16712      +18     
===========================================
+ Hits         10238    10249      +11     
- Misses        5592     5596       +4     
- Partials       864      867       +3
Impacted Files Coverage Δ
config/config.go 69.28% <27.27%> (+0.18%) ⬆️
consensus/state.go 77.3% <0%> (-0.6%) ⬇️
libs/db/remotedb/grpcdb/client.go 0% <0%> (ø) ⬆️
consensus/reactor.go 73.12% <0%> (+0.51%) ⬆️
lite/commit.go 48.71% <0%> (+0.89%) ⬆️
libs/clist/clist.go 68.18% <0%> (+1.51%) ⬆️
consensus/ticker.go 90.32% <0%> (+2.82%) ⬆️

@xla xla changed the title [config] refactor ValidateBasic config: refactor ValidateBasic Oct 1, 2018
Copy link
Contributor

@xla xla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 :octocat: :shipit: 🍡

@xla xla added distribution T:enhancement Type: Enhancement labels Oct 1, 2018
@xla xla added this to the launch milestone Oct 1, 2018
@xla xla self-assigned this Oct 1, 2018
@xla xla merged commit 32e274c into develop Oct 1, 2018
@xla xla deleted the anton/config-refactor branch October 1, 2018 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T:enhancement Type: Enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants