Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2490 +/- ##
===========================================
+ Coverage 61.4% 61.49% +0.08%
===========================================
Files 197 197
Lines 16432 16407 -25
===========================================
- Hits 10090 10089 -1
+ Misses 5507 5487 -20
+ Partials 835 831 -4
|
ebuchman
approved these changes
Sep 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should reduce file IO and disk space. For those, who want better guarantees, a note in https://tendermint.com/docs/tendermint-core/running-in-production.html is left of how to enable mempool WAL. In the future, we may want to provide better support and tooling for the mempool WAL recover procedure.
Not sure the measurements below are correct, but that's better than having no pictures 😃 These were taken using
iostat -yd 5while tendermint (kvstore) & tm-bench were running in parallel inside my virtual box.Updated all relevant documentation in docsWrote tests