libs: Handle SIGHUP explicitly inside autofile#2480
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2480 +/- ##
===========================================
- Coverage 61.7% 61.63% -0.07%
===========================================
Files 198 197 -1
Lines 16358 16332 -26
===========================================
- Hits 10093 10066 -27
Misses 5438 5438
- Partials 827 828 +1
|
melekes
commented
Sep 24, 2018
libs/autofile/autofile.go
Outdated
|
|
||
| closeTicker *time.Ticker | ||
| closeTickerStopCh chan struct{} // closed when closeTicker is stopped | ||
| hup chan os.Signal |
Contributor
There was a problem hiding this comment.
ch and Ch have a very distinct meaning in our codebase as they represent the reactor communication channels. So I'd lean towards hupc and try to use it consistently in the codebase. Attempted that with the recent Transport addition in p2p.
| t.Errorf("unexpected error %v", e) | ||
| } | ||
|
|
||
| err = af.Close() |
Contributor
Author
There was a problem hiding this comment.
note to reviewers: OpenAutoGroup now returns nil if there's an error
xla
reviewed
Sep 25, 2018
libs/autofile/autofile.go
Outdated
| Path string | ||
|
|
||
| closeTicker *time.Ticker | ||
| closeTickerStopCh chan struct{} // closed when closeTicker is stopped |
Contributor
There was a problem hiding this comment.
Probably best to rename this one as well.
🍡
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2260
Updated all relevant documentation in docsUpdated CHANGELOG_PENDING.md