Merged
Conversation
even during genesis sleep by setting up interrupt before starting a node Refs #2434
to avoid ``` E[09-24|10:13:15.805] Not stopping PubSub -- have not been started yet module=pubsub impl=PubSub ``` being printed on exit
Codecov Report
@@ Coverage Diff @@
## develop #2479 +/- ##
===========================================
- Coverage 61.7% 61.68% -0.02%
===========================================
Files 198 198
Lines 16358 16364 +6
===========================================
+ Hits 10093 10094 +1
- Misses 5438 5443 +5
Partials 827 827
|
xla
reviewed
Sep 25, 2018
| close(mt.closec) | ||
|
|
||
| return mt.listener.Close() | ||
| if mt.listener != nil { |
Contributor
There was a problem hiding this comment.
Is this to not panic when Close is called before Listen? When does that happen?
Contributor
Author
There was a problem hiding this comment.
Yes. There's a problem with the current common#Service implementation where it considers a service started before OnStart() finishes.
tendermint/libs/common/service.go
Lines 131 to 139 in 0c9c329
Therefore, calling IsRunning() can return true even though the service is not yet started (or partially started)
xla
approved these changes
Sep 25, 2018
Contributor
xla
left a comment
There was a problem hiding this comment.
👍 
🍡
Simpler, faster, stronger!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2434
Updated all relevant documentation in docsUpdated all code comments where relevantWrote tests