Merged
Conversation
Merge master to develop
Codecov Report
@@ Coverage Diff @@
## master #2473 +/- ##
==========================================
+ Coverage 61.7% 61.73% +0.03%
==========================================
Files 198 198
Lines 16358 16358
==========================================
+ Hits 10094 10099 +5
+ Misses 5437 5427 -10
- Partials 827 832 +5
|
🍡
Contributor
|
I was under the assumption that the CircleCI tests run when the PR is started. In that case there's nothing to worry about. The release process only starts when the PR is committed to master. Hence you have all the time in the world to fix the issues in the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Circle failed non-deterministically while installing dependencies the first time we merged v0.25.0 to master, so the binaries didn't get built. Lucky us, since some of the new docs links were broken. So we take the opportunity here to try merging a v0.25.0 release branch to master again, with fixed links.
@greg-szabo how should we handle non-deterministic failures like this? I re-ran the test and it passed the second time - should we make that trigger the release build ?