Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2470 +/- ##
==========================================
- Coverage 61.72% 61.7% -0.02%
==========================================
Files 198 198
Lines 16358 16316 -42
==========================================
- Hits 10097 10068 -29
+ Misses 5434 5423 -11
+ Partials 827 825 -2
|
Contributor
Author
|
Merging, but please still review :) |
melekes
reviewed
Sep 23, 2018
|
|
||
| ### Gas | ||
|
|
||
| Ethereum introduced the notion of `gas` as an absract representation of the |
| This means it does not guarantee that committed blocks satisfy these rules! | ||
| It is the application's responsibility to return non-zero response codes when gas limits are exceeded. | ||
|
|
||
| The `GasUsed` field is ignored compltely by Tendermint. That said, applications should enforce: |
| By default, Tendermint uses the `syndtr/goleveldb` package for it's in-process | ||
| key-value database. Unfortunately, this implementation of LevelDB seems to suffer under heavy load (see | ||
| [#226](https://github.com/syndtr/goleveldb/issues/226)). It may be best to | ||
| install the real C-implementaiton of LevelDB and compile Tendermint to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve documentation, including what's noted in #2467 (comment) and various issues.