Pass http.ServeTLS() errors back to the caller#2461
Merged
xla merged 4 commits intotendermint:developfrom Sep 21, 2018
alessio:alessio/2460-StartHTTPAndTLSServer-doesnt-handle-ServeTLS-failures
Merged
Pass http.ServeTLS() errors back to the caller#2461xla merged 4 commits intotendermint:developfrom alessio:alessio/2460-StartHTTPAndTLSServer-doesnt-handle-ServeTLS-failures
xla merged 4 commits intotendermint:developfrom
alessio:alessio/2460-StartHTTPAndTLSServer-doesnt-handle-ServeTLS-failures
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2461 +/- ##
===========================================
+ Coverage 61.61% 61.66% +0.05%
===========================================
Files 198 198
Lines 16292 16287 -5
===========================================
+ Hits 10038 10044 +6
+ Misses 5422 5413 -9
+ Partials 832 830 -2
|
xla
approved these changes
Sep 21, 2018
Contributor
xla
left a comment
There was a problem hiding this comment.
👍 
🍡
Great fix, thanks for the PR.
melekes
previously requested changes
Sep 21, 2018
Contributor
melekes
left a comment
There was a problem hiding this comment.
Thanks for contributing! See my comment related to StartHTTPServer function.
added 2 commits
September 21, 2018 15:37
Very valid concerns, but will require a more holistic overhaul.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When http.ServeTLS() fails, StartHTTPAndTLSServer() logs the error then hangs for ever.
It should instead pass the error back to the caller.
Closes: #2460