Conversation
| - [mempool] [\#2399](https://github.com/tendermint/tendermint/issues/2399) Make mempool cache a proper LRU (@bradyjoestar) | ||
| - [types] add Address to GenesisValidator [\#1714](https://github.com/tendermint/tendermint/issues/1714) | ||
| - [types] [\#1714](https://github.com/tendermint/tendermint/issues/1714) Add Address to GenesisValidator | ||
| - [metrics] `consensus.block_interval_metrics` is now gauge, not histogram (you will be able to see spikes, if any) |
There was a problem hiding this comment.
is this actually a breaking change? technically the metrics are an API exposed to other processes and hence need to be properly covered by SemVer unless we add an exemption in the readme
There was a problem hiding this comment.
is this actually a breaking change?
don't think so. prometheus won't crash because metric's type got changed
There was a problem hiding this comment.
will the code of any clients need to change ?
| * [mempool] \#2310 Mempool tracks the `ResponseCheckTx.GasWanted` and enforces `ConsensusParams.BlockSize.MaxGas` on proposals. | ||
|
|
||
| * Go API | ||
| * \#2310 Mempool.ReapMaxBytes -> Mempool.ReapMaxBytesMaxGas |
There was a problem hiding this comment.
Not sure why this was deleted? This is a breaking API change, as its changed the mempool interface. The new line in the Apps section does not note this API change.
There was a problem hiding this comment.
Fortunately for us maintainers, the mempool and state Go APIs are not covered by our SemVer, so we can break them as much as we want without worrying about the changelog or version bumps :). See https://github.com/tendermint/tendermint/#semver :
To provide some stability to Tendermint users in these 0.X.X days, the MINOR version is used to signal breaking changes across a subset of the total public API. This subset includes all interfaces exposed to other processes (cli, rpc, p2p, etc.), but does not include the in-process Go APIs.
Codecov Report
@@ Coverage Diff @@
## develop #2449 +/- ##
===========================================
+ Coverage 61.45% 61.46% +0.01%
===========================================
Files 197 197
Lines 16342 16342
===========================================
+ Hits 10043 10045 +2
+ Misses 5465 5463 -2
Partials 834 834
|
| - [mempool] [\#2399](https://github.com/tendermint/tendermint/issues/2399) Make mempool cache a proper LRU (@bradyjoestar) | ||
| - [types] add Address to GenesisValidator [\#1714](https://github.com/tendermint/tendermint/issues/1714) | ||
| - [types] [\#1714](https://github.com/tendermint/tendermint/issues/1714) Add Address to GenesisValidator | ||
| - [metrics] `consensus.block_interval_metrics` is now gauge, not histogram (you will be able to see spikes, if any) |
There was a problem hiding this comment.
is this actually a breaking change?
don't think so. prometheus won't crash because metric's type got changed
We should do a better job of enforcing changelog standards, of course it should be documented how it works and how to think about it in the first place. Maybe I'll write an ADR for it.
Seems like we may have missed a bunch of stuff though, so we should catch up in preparation for v0.25. It's a relatively minor release, despite at least a few breaking changes.