Skip to content

add missing RPCAddress to NodeInfoOther.String() func#2442

Merged
xla merged 1 commit intodevelopfrom
2433-node-info-fix
Sep 19, 2018
Merged

add missing RPCAddress to NodeInfoOther.String() func#2442
xla merged 1 commit intodevelopfrom
2433-node-info-fix

Conversation

@melekes
Copy link
Contributor

@melekes melekes commented Sep 19, 2018

Refs #2433

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

@codecov-io
Copy link

Codecov Report

Merging #2442 into develop will increase coverage by 0.06%.
The diff coverage is 33.33%.

@@             Coverage Diff             @@
##           develop    #2442      +/-   ##
===========================================
+ Coverage    61.28%   61.34%   +0.06%     
===========================================
  Files          198      198              
  Lines        16383    16331      -52     
===========================================
- Hits         10040    10018      -22     
+ Misses        5508     5477      -31     
- Partials       835      836       +1
Impacted Files Coverage Δ
p2p/node_info.go 50.64% <0%> (-1.3%) ⬇️
node/node.go 64.53% <100%> (-0.09%) ⬇️
libs/db/debug_db.go 16% <0%> (-4.64%) ⬇️
consensus/reactor.go 71.94% <0%> (-1.08%) ⬇️
p2p/pex/pex_reactor.go 73.33% <0%> (-0.67%) ⬇️
consensus/state.go 77.03% <0%> (+0.47%) ⬆️

Copy link
Contributor

@xla xla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 :octocat: :shipit: 🍡

@xla xla merged commit aa5495f into develop Sep 19, 2018
@xla xla deleted the 2433-node-info-fix branch September 19, 2018 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants