Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2438 +/- ##
===========================================
- Coverage 61.75% 61.63% -0.13%
===========================================
Files 198 198
Lines 16358 16316 -42
===========================================
- Hits 10102 10056 -46
+ Misses 5434 5432 -2
- Partials 822 828 +6
|
version/version.go
Outdated
| const ABCIVersion = "0.14.0" | ||
|
|
||
| // Protocol is used for implementation agnostic versioning. | ||
| type Protocol int64 |
There was a problem hiding this comment.
int64? why not the smallest uint (uint16). It can only go up, right? And there is no arithmetic
There was a problem hiding this comment.
Is this easy to update in the future? If so I'm in full support if uint16. If not, then perhaps uint32. (uint64 is definitely overkill though imo)
There was a problem hiding this comment.
Agree it should be unsigned. I went for the larger 64-bit to give us more space to signal things so that versions in the future may not be just an incrementing integer, but somehow take advantage of the bit-array, kind of like https://github.com/bitcoin/bips/blob/master/bip-0009.mediawiki
I should add that to the ADR
🍡
version/version.go
Outdated
| // updated in ResponseEndBlock. | ||
| type App struct { | ||
| Protocol Protocol | ||
| Software string |
There was a problem hiding this comment.
Should these have json struct tags as well?
version/version.go
Outdated
| const ABCIVersion = "0.14.0" | ||
|
|
||
| // Protocol is used for implementation agnostic versioning. | ||
| type Protocol int64 |
5ccfc76 to
e4ee34c
Compare
Define some new types to approach #1135 and ADR-016
Breaks out some changes from #2160