Conversation
We didn't use this code anywhere in the codebase. As such, we probably should reduce the surface area we support. In the event that we do in fact require 256 bit words inside of tendermint, we should adapt the stdlibs' internal word representations, which also handles SIMD. Inside of the SDK, a separate solution for big ints / larger words is employed, which uses big ints. This in turn does utilize the stdlibs SIMD support.
Codecov Report
@@ Coverage Diff @@
## develop #2431 +/- ##
===========================================
- Coverage 61.28% 61.18% -0.11%
===========================================
Files 198 196 -2
Lines 16383 16265 -118
===========================================
- Hits 10040 9951 -89
+ Misses 5508 5449 -59
- Partials 835 865 +30
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We didn't use this code anywhere in the codebase. As such, we probably
should reduce the surface area we support. In the event that we do
in fact require 256 bit words inside of tendermint, we should adapt
the stdlibs' internal word representations, which also handles SIMD.
Inside of the SDK, a separate solution for big ints / larger words
is employed, which uses big ints. This in turn does utilize the stdlibs
SIMD support. (Albeit in a less space efficient manner)