[rpc] transform /status result.node_info.other into map#2417
Merged
Conversation
2ce1abc to
a4e38a8
Compare
1d5634c to
f7fd422
Compare
xla
approved these changes
Sep 17, 2018
Contributor
xla
left a comment
There was a problem hiding this comment.
👍 
🍡
LGTM, yet it seems we while we touch that part of the response we could rethink how meaningful a bucket like Other is. By the looks of it there is a lot of version info in there, so might be worth breaking those out into something like Versions, which as hinted in the inline comment might be better addressed when the Versions changes come to full effect.
| other.AminoVersion, | ||
| other.P2PVersion, | ||
| other.ConsensusVersion, | ||
| other.RPCVersion} |
Contributor
There was a problem hiding this comment.
Inconsistent formatting, should be:
versions := []string{
other.AminoVersion,
other.AminoVersion,
other.P2PVersion,
other.ConsensusVersion,
other.RPCVersion,
}
Contributor
Author
|
It's pity that amino does not support maps.
good idea 👍 but I think it should be easy to extract fields and really be done in versions PR |
melekes
added a commit
that referenced
this pull request
Sep 18, 2018
and fix formatting Refs #2417 (comment)
xla
pushed a commit
that referenced
this pull request
Sep 18, 2018
and fix formatting Refs #2417 (comment)
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2391